Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hex and RGB values #213

Merged
merged 28 commits into from
May 10, 2023
Merged

Replace hex and RGB values #213

merged 28 commits into from
May 10, 2023
+787 −800

Conversation

abhijitb
Copy link
Contributor

No description provided.

@abhijitb abhijitb added the WIP PR is a Work in Progress and not ready for review. label Apr 13, 2023
arunshenoy99
arunshenoy99 reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on reviewing/making further changes to this until the crazy domains branch gets merged to trunk, we might just have to consolidate a few things for CD as well and ensure that we are on the correct variable names. Not removing the WIP until then.

EDIT: The CD branch is now merged into trunk.

@abhijitb abhijitb removed the WIP PR is a Work in Progress and not ready for review. label Apr 19, 2023
@officiallygod officiallygod added the Code Review The PR is in Code Review label May 2, 2023
@Yashita101 Yashita101 added WIP PR is a Work in Progress and not ready for review. and removed Code Review The PR is in Code Review labels May 3, 2023
@abhijitb abhijitb added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels May 3, 2023
@Yashita101 Yashita101 added QA This PR is in QA and removed Code Review The PR is in Code Review labels May 3, 2023
@arunshenoy99 arunshenoy99 added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels May 10, 2023
@arunshenoy99 arunshenoy99 merged commit 8973903 into trunk May 10, 2023
@arunshenoy99 arunshenoy99 deleted the enhance/PRESS2-563-replace-hex-rgb-values branch May 10, 2023 07:15
@abhijitb abhijitb removed the Ready to merge The Code Review and QA is done and it can be merged. label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 left review comments

@Yashita101 Yashita101 Yashita101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhijitb @arunshenoy99 @Yashita101 @officiallygod